Skip to content

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Sep 27, 2025

It's wrong to build torch, vision, and audio during release, we should just use their release candidates instead. Not only we could avoid the need to rebuild these packages, it's also the correct setup to test against RC during release

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14642

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 3 Cancelled Jobs

As of commit c9c6759 with merge base e0dda90 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 27, 2025
Signed-off-by: Huy Do <[email protected]>
@huydhn huydhn requested a review from GregoryComer September 27, 2025 07:50
@huydhn
Copy link
Contributor Author

huydhn commented Sep 27, 2025

@pytorchbot drci

@huydhn huydhn changed the title [Release only] Pin audio and vision releases [Release only] Install torch, vision, and audio RC in release branch Sep 27, 2025
@huydhn huydhn marked this pull request as ready for review September 27, 2025 07:53
@huydhn huydhn changed the title [Release only] Install torch, vision, and audio RC in release branch [Release only] Install torch, vision, and audio RC in the release branch Sep 27, 2025
@mergennachin
Copy link
Contributor

cc @GregoryComer , @psiddh, @abhinaykukkadapu please update the release manual and checklist with this step

@GregoryComer
Copy link
Member

Thanks! I see some AO failures on a few jobs, but it isn't obviously related. Maybe we were implicitly relying on some installation of AO. Given that the release branch is broken, I'm going to merge as is and take the few remaining failures as a fast follow-up.

@GregoryComer GregoryComer merged commit 79d7e14 into release/1.0 Sep 29, 2025
553 of 574 checks passed
@GregoryComer GregoryComer deleted the pin-audio-and-vision-releases branch September 29, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants